fix: raise default max fee rate from 2 to 4x estimated fee

basicswap/interface/utils.py

@@ -23,7 +23,7 @@ class FeeValidator:
     def __init__(self, **kwargs):
         default_low_fee_conf_target: int = 24
         default_low_fee_rate: int = 0
-        default_high_estimated_feerate_multiplier: float = 2.0
+        default_high_estimated_feerate_multiplier: float = 4.0
         default_high_fee_rate: int = self.defaultMaxFeeRate()
         if self._sc:
             chain_client_settings = self._sc.getChainClientSettings(
@@ -82,7 +82,7 @@ class FeeValidator:
 
         if self._high_estimated_feerate_multiplier >= 1.0:
             max_feerate, max_feerate_src = self.get_fee_rate()
-            max_feerate = (
+            max_feerate = int(
                 self.make_int(max_feerate) * self._high_estimated_feerate_multiplier
             )
         else:

basicswap/interface/xmr.py

@@ -863,5 +863,5 @@ class XMRInterface(CoinInterface):
             self._log.error(f"listWalletTransactions failed: {e}")
             return []
 
-    def validateFeeRate(self, fee_rate: int) -> bool:
+    def validateFeeRate(self, fee_rate: int) -> None:
         pass  # Fee rate isn't used

doc/release-notes.md

@@ -5,7 +5,7 @@
   - Prevent sending bids to offers
   - Reject received offers, and
   - Prevent sending offers where the chain feerates are out of range.
-  - Valid feerate range is the nodes estimated feerate for confirmation in 24 blocks to 2x the estimated feerate.
+  - Valid feerate range is the node's estimated feerate for confirmation in 24 blocks to 4x the estimated feerate.
     - The minimum feerate confirmation can be adjusted with the "low_fee_conf_target" setting.
     - If "low_feerate" is set above 0 it is used instead of the dynamic feerate with "low_fee_conf_target"
     - The maximum feerate multiplier can be adjusted with the "high_estimated_feerate_multiplier" setting.