From 5c8f1bc6d13d746ff4c07b36ddb7427315859ad2 Mon Sep 17 00:00:00 2001 From: tecnovert Date: Sat, 30 May 2026 21:51:31 +0200 Subject: [PATCH] fix: raise default max fee rate from 2 to 4x estimated fee --- basicswap/interface/utils.py | 4 ++-- basicswap/interface/xmr.py | 2 +- doc/release-notes.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/basicswap/interface/utils.py b/basicswap/interface/utils.py index 409f667..870a3f0 100644 --- a/basicswap/interface/utils.py +++ b/basicswap/interface/utils.py @@ -23,7 +23,7 @@ class FeeValidator: def __init__(self, **kwargs): default_low_fee_conf_target: int = 24 default_low_fee_rate: int = 0 - default_high_estimated_feerate_multiplier: float = 2.0 + default_high_estimated_feerate_multiplier: float = 4.0 default_high_fee_rate: int = self.defaultMaxFeeRate() if self._sc: chain_client_settings = self._sc.getChainClientSettings( @@ -82,7 +82,7 @@ class FeeValidator: if self._high_estimated_feerate_multiplier >= 1.0: max_feerate, max_feerate_src = self.get_fee_rate() - max_feerate = ( + max_feerate = int( self.make_int(max_feerate) * self._high_estimated_feerate_multiplier ) else: diff --git a/basicswap/interface/xmr.py b/basicswap/interface/xmr.py index a784f65..cd02b67 100644 --- a/basicswap/interface/xmr.py +++ b/basicswap/interface/xmr.py @@ -863,5 +863,5 @@ class XMRInterface(CoinInterface): self._log.error(f"listWalletTransactions failed: {e}") return [] - def validateFeeRate(self, fee_rate: int) -> bool: + def validateFeeRate(self, fee_rate: int) -> None: pass # Fee rate isn't used diff --git a/doc/release-notes.md b/doc/release-notes.md index d8207cf..3fc3035 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -5,7 +5,7 @@ - Prevent sending bids to offers - Reject received offers, and - Prevent sending offers where the chain feerates are out of range. - - Valid feerate range is the nodes estimated feerate for confirmation in 24 blocks to 2x the estimated feerate. + - Valid feerate range is the node's estimated feerate for confirmation in 24 blocks to 4x the estimated feerate. - The minimum feerate confirmation can be adjusted with the "low_fee_conf_target" setting. - If "low_feerate" is set above 0 it is used instead of the dynamic feerate with "low_fee_conf_target" - The maximum feerate multiplier can be adjusted with the "high_estimated_feerate_multiplier" setting.