Fix: Prevent silent wallet creation. (#444)

* Fix: Prevent silent wallet creation.

* Error on wallet name mismatch + fix wording.

* Revert init_wallet

* Don't create wallet on startup if other wallets exist on disk.

* Added back # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors

basicswap/interface/btc.py

@@ -394,10 +394,17 @@ class BTCInterface(Secp256k1Interface):
             except Exception as e:
                 self._log.debug(f'Error loading wallet "{self._rpc_wallet}": {e}.')
                 if "does not exist" in str(e) or "Path does not exist" in str(e):
+                    try:
+                        wallet_dirs = self.rpc("listwalletdir")
+                        existing = [w["name"] for w in wallet_dirs.get("wallets", [])]
+                    except Exception:
+                        existing = []
+                    if len(existing) == 0:
                         self._log.info(
                             f'Creating wallet "{self._rpc_wallet}" for {self.coin_name()}.'
                         )
                         try:
+                            # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors
                             self.rpc(
                                 "createwallet",
                                 [
@@ -3842,6 +3849,7 @@ class BTCInterface(Secp256k1Interface):
     def createWallet(self, wallet_name: str, password: str = "") -> None:
         if self._connection_type == "electrum":
             return
+        # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors
         self.rpc(
             "createwallet",
             [wallet_name, False, True, password, False, self._use_descriptors],
@@ -4092,6 +4100,18 @@ class BTCInterface(Secp256k1Interface):
             # Required when encrypting an existing btc/ltc wallet, or switching from electrum to rpc mode. Workaround is to delete the btc/ltc wallet and recreate.
             wallets = self.rpc("listwallets")
             if self._rpc_wallet not in wallets:
+                try:
+                    self.rpc("loadwallet", [self._rpc_wallet])
+                except Exception as e:
+                    if "does not exist" in str(e) or "Path does not exist" in str(e):
+                        try:
+                            wallet_dirs = self.rpc("listwalletdir")
+                            existing = [
+                                w["name"] for w in wallet_dirs.get("wallets", [])
+                            ]
+                        except Exception:
+                            existing = []
+                        if len(existing) == 0:
                             self._log.info(
                                 f'Creating wallet "{self._rpc_wallet}" for {self.coin_name()}.'
                             )
@@ -4107,6 +4127,8 @@ class BTCInterface(Secp256k1Interface):
                                     self._use_descriptors,
                                 ],
                             )
+                    else:
+                        raise
 
             try:
                 seed_id = self.getWalletSeedID()

basicswap/interface/ltc.py

@@ -50,10 +50,17 @@ class LTCInterface(BTCInterface):
             except Exception as e:
                 self._log.debug(f'Error loading wallet "{self._rpc_wallet}": {e}.')
                 if "does not exist" in str(e) or "Path does not exist" in str(e):
+                    try:
+                        wallet_dirs = self.rpc("listwalletdir")
+                        existing = [w["name"] for w in wallet_dirs.get("wallets", [])]
+                    except Exception:
+                        existing = []
+                    if len(existing) == 0:
                         self._log.info(
                             f'Creating wallet "{self._rpc_wallet}" for {self.coin_name()}.'
                         )
                         try:
+                            # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors
                             self.rpc(
                                 "createwallet",
                                 [
@@ -192,9 +199,20 @@ class LTCInterface(BTCInterface):
 
         wallets = self.rpc("listwallets")
         if self._rpc_wallet not in wallets:
+            try:
+                self.rpc("loadwallet", [self._rpc_wallet])
+            except Exception as e:
+                if "does not exist" in str(e) or "Path does not exist" in str(e):
+                    try:
+                        wallet_dirs = self.rpc("listwalletdir")
+                        existing = [w["name"] for w in wallet_dirs.get("wallets", [])]
+                    except Exception:
+                        existing = []
+                    if len(existing) == 0:
                         self._log.info(
                             f'Creating wallet "{self._rpc_wallet}" for {self.coin_name()}.'
                         )
+                        # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors
                         self.rpc(
                             "createwallet",
                             [
@@ -206,6 +224,8 @@ class LTCInterface(BTCInterface):
                                 self._use_descriptors,
                             ],
                         )
+                else:
+                    raise
 
         try:
             seed_id = self.getWalletSeedID()
@@ -298,6 +318,7 @@ class LTCInterfaceMWEB(LTCInterface):
                     self._log.info(
                         f'Creating wallet "{self._rpc_wallet}" for {self.coin_name()}.'
                     )
+                    # wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors
                     self.rpc(
                         "createwallet",
                         [